Staffbot crashes when checking warnings

[Maverick]

Nethila: "When checking warnings via Staffbot, please keep in mind that staffbot wont take names that has ' or " in them. Those names will kill staffbot just like that. So if you accidently killed it, just spawn it or get a mod to do it for you off RoboQueen."

[dugwyler]

This should now be fixed. In the warning-check SQL queries, slashes were not being added. Will not close this ticket until someone verifies this is now working.

[Maverick]

Notice that this bot isn't used on Roboking so it won't be automatically tested after a SVN update.

This bot should be given a temporary name and spawned just to test if this bug has been fixed.

[dugwyler]

Well, this one definitely sounded like an addSlashesToString problem, and that method was not used on the query ... therefore I think it's a safe bet (95%) that this fixed it. Reopen if not fixed.

[Maverick]

No, please don't close it until it's tested that it's fixed. Otherwise it's forgotten.

[dugwyler]

Well, fair enough -- the others should be reopened then as well.

This one, though, of any of these tickets, I think is the most likely to be fixed... so that it's ironic you chose to reopen it in particular.

How are we testing these? There was mention of running StaffBot on a different name. Is there an individual in charge of verifying things work?

[Maverick]

The one who fixed the problem should also test if it works himself, it's part of fixing the whole problem imo.

You can test it by putting up your own bot core in TW Dev zone or contact me for testing it in TW (which should only be done if it's absolutely impossible to test it yourself).
If you need a test database with test data, you can contact me for credentials for connecting to a TW database on twcore.org.

[freakmonger]

It still crashes for me.

java.lang.NullPointerException

at twcore.bots.staffbot.staffbot.queryWarningsFrom(staffbot.java:238)
at twcore.bots.staffbot.staffbot.handleEvent(staffbot.java:188)
at twcore.core.net.GamePacketInterpreter.handleChatMessage(GamePacketInterpreter.java:468)
at twcore.core.net.GamePacketInterpreter.translateNormalPacket(GamePacketInterpreter.java:188)
at twcore.core.net.GamePacketInterpreter.translateGamePacket(GamePacketInterpreter.java:136)
at twcore.core.net.ReliablePacketHandler.handleReliableMessage(ReliablePacketHandler.java:88)
at twcore.core.net.GamePacketInterpreter.translateSpecialPacket(GamePacketInterpreter.java:310)
at twcore.core.net.GamePacketInterpreter.translateGamePacket(GamePacketInterpreter.java:134)
at twcore.core.Session.run(Session.java:310)

[Maverick]

freakmonger, you did use the latest version from the repository?

[Maverick]

Staffbot still crashes when you do !warnings bla"bla .

[Maverick]

This ticket has been summarized in ticket:108.