Turn off ?obscene filter on Matchbot and Robo Ref

[PH]

Dengue just reported this to me, so I'm going to combine his findings with two of my own and make one big ticket out of this.

Players can't be !rank'd by the Robo Refs if their name begins with "unt" (i.e. untie, Untame). I tried it myself -- the bots return nothing and act as if the command is the furthest thing from their robotic minds.

Similarly, MatchBots ignore the !lag command when it's issued for a name beginning with "er" or "ger".

I'm pretty sure the server's list of obscene words is somehow interfering with the commands. When I try to PM myself the commands with the filter on, they don't go through. "rank unt" is kind of obvious, but I don't know why "lag er" and "lag ger" would be filtered.

Solution? That's for you to figure out, I'm just the messenger, heh.

[Maverick]

Unfortunately we don't have control over either of the bots; Matchbot or Robo Ref. When we do gain control, I'll look into it.

[Maverick]

Please don't close this without specifying a reason or your identity.

[Ayano]

Ah that was me, I was at campus. It's just that there are numerous open tickets weren't going anywhere so I thought I'd close this one to prevent a build up.

[Maverick]

I would recommend just leaving the tickets open until they are fixed. This way the tickets aren't forgotten (since they are closed) and it gives some insight into how swamped we are ;).

This ticket I have to check once I get access to RoboQueen.

[Ayano]

RoboQueen? You hope for the impossible.

[Maverick]

One must keep hope alive or everything is lost :p

[anonymous]

I will make Matchbot turn off the obscene filter. When access to RoboQueen is given, a simple update from the repository can be done to resolve this issue.

We have no source code of Robo Ref so we can't do anything about that.

Might be an idea to create "reliable" methods in BotAction for turning off ?obscene / *lock and other toggle commands:
These methods do the command and set a boolean variable to mark the wanted state of the command. Checking the arena messages ("Arena LOCKED" and "Obscene filter OFF") in combination with the boolean can check if the command needs to be done again to reach the desired state.

I will check if these methods are doable given that the class must stay able to be multithreaded.

[Maverick]

Previous changes and comments were done by me btw

[milosh]

What's up with this ticket?

[Maverick]

I think I forgot about this one.

Someone need to add "?obscene" command to MatchBot after logging in and checking the returned arena message if it actually turned the obscene filter OFF. ("Obscene filter OFF")

[dugwyler]

Every bot by default turns on the ?obscene filter in GamePacketInterpreter's handlePasswordPacketResponse message. As far as I know this has been the case for a very long time.

It may have actually been the case that the reason MatchBot was not working is because it already *sent* ?obscene, thinking that it was not already automatically sent; the special fix in MatchBot is probably highly redundant, because first it turns ON obscene, then checks the arena message that says it's turned on, and then turns it off.

An obvious example of the default ?obscene working is the spy module of PubBot, which needs to be able to report certain remarks, but does not send ?obscene.

I recommend we remove all special ?obscene handling in MatchBot, as it's completely unnecessary. I've already taken the liberty to remove the ?obscene send from ZonerBot, which of course actually turns the filter back on. All other bots seem to be free of counterproductive ?obscene sends.

[Maverick]

Yes, extra ?obscene handling in MatchBot should be removed.

Once done, this ticket can be closed.

[Maverick]

Extra ?obscene handling in MatchBot was removed 4 weeks ago.
Related changesets: [3364] and [3365]

[Maverick]

To be exact, ?obscene handling in MatchBot was bugfixed as turning off ?obscene at the MatchBots upon logging in wasn't working. (changeset [3365])