Add comments to mid/ip/name watches

[Mr. 420]

For those of us who use pubhub, to be able to add a small comment on why they're under "watch" would be helpful to others who check the "watches" after the original staff member is gone, as to why that person/mid/ip was being watched.

[Rudy]

Need this one bumped up in priority as the frequent number of watches required lately can not be adequately followed through by other operators who encounter matches because they do not have any reference on the case without more ridiculous forum threads being made. Would like this comment enhancement rolled out with the next King update if at all possible thankyou.

[Maverick]

Done, will commit & test soon.

[Maverick]

Changes have been done to pubhub, committed to source repository and pubhub has been updated in Trench Wars.

Rudy, I've currently made the <reason> part of !ipwatch 123:<reason> mandatory because I figured it would be good if we always specify a reason / comment for each watch. However, (as cool koen and Left_Eye pointed out) it isn't very userfriendly (although it might just be that it takes a bit to get used to).
What is your opinion on this?

[Rudy]

We're better off keeping the reason mandatory. It avoids situations where one might otherwise forget to comment and then it is no better than it was beforehand. Even if the watch is merely set to aquire someone switching names every few minutes to TK, doesn't take much more than a second or two to tag it with :TK.
Cheers for getting this done so hastily.

[Maverick]

Agreed.
Ticket closed

[Maverick]

Convenience matter

TODO:

• Save the watches to (preferably) the .cfg file so they are saved if the pubhub goes down.

[Maverick]

Done
Will commit soon.

[Maverick]

Committed in changeset:2436