Ticket #374 (closed task: fixed)

Opened 15 months ago

Last modified 7 months ago

Move the hard-coded resolution for bots to configuration

Reported by: Maverick Owned by:
Priority: normal Component: Core
Version: Latest version from repository Severity: minor
Keywords: Cc:

Description

Currently in BotAction.joinArena(short arena) the resolution is hard-coded to 1024x768 (parameter to GamePacketGenerator.sendArenaLoginPacket()). This should be made configurable in setup.cfg.

Task:

  • Add two configuration variables to setup.cfg for configuring the default resolution.
  • Retrieve these configuration variables from the setup.cfg and use it as the default resolution in BotAction.joinArena().

Attachments

Change History

Changed 12 months ago by Maverick

  • owner nobody deleted

Changed 11 months ago by JoyRider

I would like to take this ticket, but i can't assign it to myself(?)

Changed 11 months ago by JoyRider

Ok, it's already done, but i can't commit it. I get some error.

Changed 11 months ago by milosh

When the ticket has no owner, use accept. Telling us you get some error won't help us help you. What is the error?

Changed 11 months ago by Maverick

Perhaps because you don't have access to commit any code because you've been removed from the dev team on 19th may 2009 (for inactiveness).

http://forums.trenchwars.org/showthread.php?p=717480#post703999

If you want to have your code added to the repository, e-mail it to me (maverick[@t]dedicational.com)

Changed 11 months ago by Maverick

I didn't want to sound offensive or harsh in my previous post. My apologies if I did.

JoyRider, if you want to rejoin, let me know. I would really appreciate your help.

Changed 11 months ago by JoyRider

I actually already expected that, just wanted you guys to break the ice as nobody ever bothered to tell me ;) Anyway emailing the changes.

Changed 11 months ago by Maverick

Changes checked in at changeset [3377]

Changed 7 months ago by Maverick

  • status changed from new to closed
  • resolution set to fixed

Everything seems to work well.

Add/Change #374 (Move the hard-coded resolution for bots to configuration)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.