Ticket #466 (closed defect: wontfix)

Opened 7 months ago

Last modified 4 months ago

Matchbots, every normal player can challenge/accept matches!

Reported by: M_M God Owned by:
Priority: highest Component: Bots - TWD/TWL
Version: Latest version from repository Severity: critical
Keywords: Cc:

Description

We discovered a big flaw in the Matchbots yesterday, where EVERY player can accept/challenge for TWD Matches, bot doesn't check if someone is an assistant or not. For example: http://twd.trenchwars.org/showgame/90019567 - Vatican Assassin accepted the match, he has never been an assistant for us. Lateron I tested it and Jason accepted a jd for us, neither being an assistant. Important fix needed.

Attachments

Change History

Changed 4 months ago by Arobas+

  • status changed from new to closed
  • resolution set to wontfix

isRankAssistantMinimum() currently checks only if fnRankID is higher or equal to 3.

1 = Guest
2 = Player
3 = Assistant
4 = Captain
..
6 = ER
..

Any players on the staff would be able to accept/challenge a match because of that. Unfortunately, sometimes the rank is kept on the DB for unknown reasons. I did a clean up 1 month ago, it should have fixed the problem. But the code is fine.

Add/Change #466 (Matchbots, every normal player can challenge/accept matches!)

Author


E-mail address and user name can be saved in the Preferences.


Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.