Ticket #84 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

TWDBot squadsignup failure

Reported by: Rudy Assigned to:
Priority: high Component: Bots - Other
Version: Latest version from repository Severity: critical
Keywords: Cc:

Description

This problem may already be in the works to be addressed, but since I do not see a ticket regarding it… The !squadsignup command is doing two different things.

1.) The player registering the squad is not automatically given captainship of the new squad and instead shown as a de-rostered member of the last registered squad. The captain must be manually made an applicant to their own squad and promoted to cap.
2.) The player registering the squad is made a rostered captain of the last registered squad. They have to be delisted from the wrong squad and manually applied to their correct squad and given captainship as in 1.

Needs immediate attention if indeed it is a bot-side flaw.

Attachments

Change History

06/27/07 14:14:22 changed by Maverick

I helped Magnetic today with registering his squad on TWD but it totally fucked up (as I expected after reading this ticket):

  1. He leaves his squad Savanger to be able to register his own squad, Chocotone, on TWD.
  2. After he does this he's suddenly a captain of flamewave. (For real, I checked)
  3. Waiting for him I register my squad on TWD (TW-Dev), after he registered his squad.
  4. Now I'm suddenly captain of Chocotone, while my own squad remains memberless. [!]

We need to get this fixed asap :)

06/27/07 20:07:49 changed by Rudy

Also worth noting. This is the second time I've had to place a captain back on his own roster following this bug, because he's being somehow removed from it without having done anything.

06/27/07 23:43:10 changed by Maverick

Rudy, you are saying captains now get randomly removed from their squad or after a command to TWDBot ?

06/27/07 23:53:04 changed by Maverick

  • priority changed from highest to high.
  • severity changed from minor to critical.

06/28/07 06:43:23 changed by anonymous

I'm saying it happened the first time and after fixing him, I told him to let us know the instant it happens again if it does. It did. He only just started this squad like two days ago, so it's quite unlikely that Fire Phoenix is just doing this to fuck with us in a rather untimely fashion. Looking at the TWD site, the logs have an entry that say that he left, but not how. I can't be sure if these two problems are tied together or this is something different altogether wrong with the bot.

06/29/07 09:13:07 changed by Unexpected

It is true. Happened to me, left BoZ, made Cojones, and wasnt cap of it. also the 2 days rule was beeing applied uncorrectly to me. Can i suggest something? just disable the command !squadregister on twd bot? so the rest will still be working fine.

06/29/07 15:09:05 changed by Maverick

I just tried to replicate this bug in my development environment but it worked fine there. I'm quite puzzled as to why the bot does these weird things.

Next step; Replicate the bug in TW with the real TWDBot and then examine the database for a clue to the bug.

06/30/07 12:11:02 changed by Maverick

  • status changed from new to closed.
  • resolution set to fixed.

The !squadsignup problem was caused because of a backgroundquery right before a direct query which was requesting the latest inserted squad ID to associate the player with.
The backgroundquery, which inserted the squad into the database, would always execute after this query so you would be made captain of the last inserted squad which wasn't the squad of the player doing !squadsignup.

See changeset:1619.

Add/Change #84 (TWDBot squadsignup failure)




Change Properties
Action